Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nx plugin - configuration generator for standalone workspace layout #61

Closed
4 tasks
BioPhoton opened this issue Sep 22, 2023 · 1 comment · Fixed by #294
Closed
4 tasks

nx plugin - configuration generator for standalone workspace layout #61

BioPhoton opened this issue Sep 22, 2023 · 1 comment · Fixed by #294
Assignees

Comments

@BioPhoton
Copy link
Collaborator

The nx plugin should have a generator that is responsible for adding the code-pushup.config.json to a project in the workspace.

Todo:

  • The project should get added over a CLI argument
  • The project, if not given in the CLI arguments, should show up as select options in the CLI prompts
  • In a standalone workspace layout a script should get added to the root package.json
  • In a common workspace layout (e.g. libs/apps) an error should get thrown that mentions that the feature will be implemented in the future.
@BioPhoton BioPhoton changed the title nx plugin - configuration generator nx plugin - configuration generator Sep 22, 2023
@BioPhoton BioPhoton changed the title nx plugin - configuration generator nx plugin - configuration generator for standalone workspace layout Sep 22, 2023
@vmasek vmasek added this to the 2. Integration milestone Oct 11, 2023
@IKatsuba IKatsuba self-assigned this Nov 20, 2023
IKatsuba added a commit that referenced this issue Nov 20, 2023
@IKatsuba
Copy link
Contributor

IKatsuba commented Nov 20, 2023

  1. Why should we throw an error in the common layout? Technically, standalone and common layouts are the same things. I'd like to write a warning message for all layouts. For example:
@code-pushup/nx-plugin is not fully ready. For now, you have to run code-pushup with the following command:

code-pushup <command> --config={projectRoot}/{fileName}

In the future, we plan to add the Code PushUp executor.

Or we can add a command with code-pushup collect with the config option as a target.

  1. Why should we add config to package.json? The separated config is more extendable.

IKatsuba added a commit that referenced this issue Nov 20, 2023
IKatsuba added a commit that referenced this issue Nov 21, 2023
IKatsuba added a commit that referenced this issue Nov 21, 2023
IKatsuba added a commit that referenced this issue Nov 23, 2023
IKatsuba added a commit that referenced this issue Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants