Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(plugin-coverage): skip missing coverage for empty-report function #689

Merged
merged 2 commits into from
Jun 3, 2024

Conversation

Tlacenka
Copy link
Collaborator

Closes #647

In this PR, I skip missing coverage for functions called (empty-report). They usually point to the first line of a file, an import or export. Therefore, this seems like an invalid function identification.

@Tlacenka Tlacenka requested a review from matejchalk May 29, 2024 15:39
@Tlacenka Tlacenka self-assigned this May 29, 2024
@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 coverage-plugin labels May 29, 2024
@Tlacenka Tlacenka force-pushed the coverage-plugin/remove-empty-function branch from 2de12dd to 68e2494 Compare May 29, 2024 15:42
Copy link

github-actions bot commented May 29, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit a7466b8 with source commit abe0cd2.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Code coverage 🟡 89 🟡 80 ↑ +9.1
Performance 🟡 69 🟡 65 ↑ +3.3
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 95 🟢 95
Updates 🟡 89 🟡 89
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Code coverage Code coverage metrics 🟡 89 🟡 80 ↑ +9.1
Lighthouse Performance 🟡 69 🟡 65 ↑ +3.3

19 other groups are unchanged.

🛡️ Audits

👍 10 audits improved, 👎 3 audits regressed, 9 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Avoid large layout shifts 🟥 4 elements found 🟩 4 elements found  −∞ %
Lighthouse Avoid large layout shifts 🟥 15 layout shifts found 🟩 15 layout shifts found  −∞ %
Lighthouse Cumulative Layout Shift 🟨 0.144 🟩 0.006  −∞ %
Lighthouse First Contentful Paint 🟩 1.5 s 🟨 2.3 s ↓ −37 %
Lighthouse Speed Index 🟩 3.0 s 🟨 4.4 s ↓ −31 %
Code coverage Function coverage 🟩 91 % 🟨 76 % ↑ +20 %
Lighthouse First Meaningful Paint 🟩 1.5 s 🟨 2.6 s ↓ −45 %
Lighthouse Total Blocking Time 🟥 880 ms 🟥 1,260 ms ↓ −30 %
Lighthouse Time to Interactive 🟩 2.5 s 🟨 4.1 s ↓ −38 %
Lighthouse Largest Contentful Paint 🟨 2.8 s 🟨 3.0 s ↓ −6 %
Lighthouse Max Potential First Input Delay 🟥 510 ms 🟥 570 ms ↓ −11 %
Code coverage Line coverage 🟩 91 % 🟩 91 %  +0 %
Code coverage Branch coverage 🟨 83 % 🟨 83 %  +0 %
Lighthouse Metrics 🟩 2541 🟩 4081 ↓ −38 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 431 KiB 🟩 Total size was 432 KiB ↓ +0 %
Lighthouse Minimizes main-thread work 🟥 3.8 s 🟥 5.0 s ↓ −24 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↓ +0 %
Lighthouse Properly size images 🟥 Potential savings of 239 KiB 🟥 Potential savings of 240 KiB ↑ +∞ %
Lighthouse JavaScript execution time 🟩 0.1 s 🟩 0.2 s ↓ −66 %
Lighthouse Network Round Trip Times 🟩 20 ms 🟩 0 ms ↑ +2000 %
Lighthouse Server Backend Latencies 🟩 30 ms 🟩 50 ms ↓ −37 %
Lighthouse Initial server response time was short 🟩 Root document took 20 ms 🟩 Root document took 0 ms ↑ +700 %

500 other audits are unchanged.

matejchalk
matejchalk previously approved these changes May 29, 2024
Copy link
Collaborator

@matejchalk matejchalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call 👍

@github-actions github-actions bot added 🦾 CI/CD continuous integration and deployment 🛠️ tooling labels May 30, 2024
@Tlacenka Tlacenka force-pushed the coverage-plugin/remove-empty-function branch from 5816e84 to 2501202 Compare June 3, 2024 13:46
@github-actions github-actions bot removed 🦾 CI/CD continuous integration and deployment 🛠️ tooling labels Jun 3, 2024
@Tlacenka Tlacenka requested a review from matejchalk June 3, 2024 13:47
@Tlacenka Tlacenka merged commit ed5cb9b into main Jun 3, 2024
16 of 19 checks passed
@Tlacenka Tlacenka deleted the coverage-plugin/remove-empty-function branch June 3, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 coverage-plugin 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issues with coverage plugin
2 participants