Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-js-packages): calculate total dependencies from package.json #690

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Tlacenka
Copy link
Collaborator

Closes #597

In this PR I fix the way of calculating outdated score. Now the number of all dependencies of a given type is used to create the ratio of outdated major dependencies.

At the moment, only one package.json can be referenced to calculate the total.

@Tlacenka Tlacenka requested a review from matejchalk May 30, 2024 17:48
Copy link

nx-cloud bot commented May 30, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8a03b13. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected:e2e --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@github-actions github-actions bot added 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests 🧩 js-packages-plugin Plugin for audit and outdated dependencies labels May 30, 2024
Copy link

github-actions bot commented May 30, 2024

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared target commit 203aaa9 with source commit 0a72931.

🏷️ Categories

🏷️ Category ⭐ Current score ⭐ Previous score 🔄 Score change
Performance 🟡 57 🟢 90 ↓ −33.4
Updates 🟡 89 🟡 80 ↑ +8.1
Code coverage 🟡 80 🟡 80 ↑ +0
Accessibility 🟢 100 🟢 100
Best Practices 🟢 100 🟢 100
SEO 🟡 86 🟡 86
PWA 🟡 63 🟡 63
Bug prevention 🟢 100 🟢 100
Code style 🟢 99 🟢 99
Security 🟢 95 🟢 95
Custom checks 🟡 67 🟡 67

🗃️ Groups

👍 2 groups improved, 👎 1 group regressed
🔌 Plugin 🗃️ Group ⭐ Current score ⭐ Previous score 🔄 Score change
Lighthouse Performance 🟡 57 🟢 90 ↓ −33.4
JS Packages NPM outdated dependencies 🟡 89 🟡 80 ↑ +8.1
Code coverage Code coverage metrics 🟡 80 🟡 80 ↑ +0

18 other groups are unchanged.

🛡️ Audits

👍 6 audits improved, 👎 10 audits regressed, 7 audits changed without impacting score
🔌 Plugin 🛡️ Audit 📏 Current value 📏 Previous value 🔄 Value change
Lighthouse Minimizes main-thread work 🟥 6.2 s 🟩 1.9 s ↑ +224 %
Lighthouse Avoid large layout shifts 🟩 4 elements found 🟥 5 elements found  −∞ %
Lighthouse Avoid large layout shifts 🟩 15 layout shifts found 🟥 15 layout shifts found  −∞ %
Lighthouse Total Blocking Time 🟥 1,750 ms 🟩 90 ms ↑ +1960 %
Lighthouse Max Potential First Input Delay 🟥 760 ms 🟨 220 ms ↑ +242 %
Lighthouse Speed Index 🟨 5.2 s 🟩 1.8 s ↑ +193 %
Lighthouse First Contentful Paint 🟨 2.7 s 🟩 1.1 s ↑ +146 %
Lighthouse First Meaningful Paint 🟨 3.1 s 🟩 1.1 s ↑ +179 %
Lighthouse Cumulative Layout Shift 🟩 0.006 🟨 0.147  −∞ %
Lighthouse Time to Interactive 🟨 4.7 s 🟩 2.5 s ↑ +90 %
Lighthouse Largest Contentful Paint 🟨 3.4 s 🟨 2.7 s ↑ +25 %
JS Packages Outdated NPM dev dependencies. 🟨 57 outdated package versions (27 major, 24 minor, 5 patch, 1 prerelease) 🟨 57 outdated package versions (27 major, 24 minor, 5 patch, 1 prerelease)  +0 %
JS Packages Outdated NPM prod dependencies. 🟩 7 outdated package versions (1 major, 2 minor, 4 patch) 🟨 7 outdated package versions (1 major, 2 minor, 4 patch)  +0 %
Code coverage Line coverage 🟩 91 % 🟩 91 %  +0 %
Code coverage Function coverage 🟨 76 % 🟨 76 %  +0 %
Code coverage Branch coverage 🟨 83 % 🟨 83 %  +0 %
Lighthouse Metrics 🟩 4727 🟩 2484 ↑ +90 %
Lighthouse Properly size images 🟥 Potential savings of 240 KiB 🟥 Potential savings of 240 KiB ↓ −100 %
Lighthouse JavaScript execution time 🟩 0.2 s 🟩 0.0 s ↑ +761 %
Lighthouse Avoids enormous network payloads 🟩 Total size was 432 KiB 🟩 Total size was 432 KiB ↑ +0 %
Lighthouse Uses efficient cache policy on static assets 🟨 11 resources found 🟨 11 resources found ↑ +0 %
Lighthouse Server Backend Latencies 🟩 20 ms 🟩 10 ms ↑ +167 %
Lighthouse Network Round Trip Times 🟩 0 ms 🟩 10 ms ↓ −78 %

499 other audits are unchanged.

@Tlacenka Tlacenka force-pushed the js-packages/total-dependencies branch from bc0b60a to 8a03b13 Compare June 3, 2024 13:33
@Tlacenka Tlacenka requested a review from matejchalk June 3, 2024 13:34
@Tlacenka Tlacenka merged commit abe0cd2 into main Jun 3, 2024
18 of 19 checks passed
@Tlacenka Tlacenka deleted the js-packages/total-dependencies branch June 3, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 js-packages-plugin Plugin for audit and outdated dependencies 📖 Project documentation improvements or additions to the project documentation 🔬 testing writing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Packages plugin issues
2 participants