TASK: Support large button labels #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I added a second variant, that fits the buttons in one line again, but removes the "Copy .." / "Kopiere .." prefix of the button label, and replaces it with moving the copy icon from right to left, before the button label. Like that, we only have "Neos-Link" and "Link" to translate, which might fit for all languages. In addition i reworked the AnchorView a bit to re-use more native Neos UI components and tested it for Neos 7 LTS, the lower boundary of supported Neos releases. |
- Fix inclusion of style.css. - Add detailed button tooltips. - Use native Neos UI icon component instead of custom SVGs and CSS styles to align with similar icon presentations. - Set fixed icon width and height for all button states to prevent buttons from shrinking and enlarging. - Buttons evenly consume all available space.
alexander-nitsche
force-pushed
the
task-adapt-button-size
branch
from
edf7cf4
to
7a79566
Compare
- Move all style definitions from AnchorView.js to style.css. - Change copy buttons from fixed size to auto size to be more flexible with different label lengths. - Leave SectionIdEditor.js unchanged, as it should remain comparable to the original Neos.Neos.Ui/packages/neos-ui-editors/src/Editors/UriPathSegment/index.js.
|
Hi guys, would be great to get this in. Thanks and greetings, Alex |
gradinarufelix
approved these changes
May 22, 2023
|
Thanks for your PR @alexander-nitsche ! We just found time to check it. It's merged and released: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6