Add unit tests #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krsriq
requested changes
Sep 27, 2023
There was a problem hiding this comment.
This is coming together quite nicely! Just a couple of cleanup tasks.
Depending on how far you want to go with this, there are a couple of obvious refactoring opportunities here
- the
$from/$toparsing ingetRecordingscould be moved to a separate method (code repetition, andgetRecordingsis kind of long and does a lot imo) - move
getAccessTokento a separate class (kind of smelly that this can't be tested..)
krsriq
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
2 times, most recently
from
65e9173
to
11ee4bd
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
krsriq
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
from
11ee4bd
to
1092669
Compare
krsriq
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
from
1092669
to
69a074c
Compare
|
Review again. I moved the |
krsriq
requested changes
Sep 28, 2023
Co-authored-by: Daniel Schmelz <daniel@schmelz.org>
krsriq
requested changes
Oct 3, 2023
| @@ -236,51 +224,13 @@ private function fetchPaginatedData(string $uri, string $paginatedDataKey): arra | |||
| throw new ZoomApiException(sprintf('Could not fetch Zoom paginated data for data key "%s", returned status "%s"', $paginatedDataKey, $response->getStatusCode()), 1695239983421); | |||
There was a problem hiding this comment.
This line is still suspiciously not covered by tests - and has a bug (guess you can find it on your own ;) ).
There was a problem hiding this comment.
Sollte jetzt gefixt sein, was meinst du? ;-)
Ich habe jetzt auch noch PHPStan hinzugefügt und Codesniffer
gradinarufelix
force-pushed
the
switch-to-s2s-oauth-apps-tests
branch
from
b0a1310
to
9fbf997
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
composer installcomposer test