Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CheckCRCLocalDNSReachableFromHost should check the IP it resolves #1013

Closed
cfergeau opened this issue Feb 14, 2020 · 0 comments · Fixed by #1042
Closed

CheckCRCLocalDNSReachableFromHost should check the IP it resolves #1013

cfergeau opened this issue Feb 14, 2020 · 0 comments · Fixed by #1042

Comments

@cfergeau
Copy link
Contributor

Currently CheckCRCLocalDNSReachableFromHost tries to resolve api.crc.testing and foo.crc-apps.testing, but it's not verifying they resolved to the VM IP
It's possible to have non-working DNS configurations where unknown names would resolve to an IP, so it would be better to check we resolved these hostnames to a known IP.
@cfergeau cfergeau mentioned this issue Feb 25, 2020
Closed
cfergeau added a commit to cfergeau/crc that referenced this issue Feb 26, 2020
@cfergeau
Issue crc-org#1013: Check resolved IP in CheckCRCLocalDNSReachableFro…
1685d78 
…mHost

CheckCRCLocalDNSReachableFromHost checks that the api.crc.testing and
foo.apps-crc.testing hostnames can be resolved, but it does not check
this returns the IP of the VM. This commit adds an additional check
that the resolved IP matches the IP of the VM as this could help crc
detect some host misconfigurations early.

This resolves crc-org#1013
@cfergeau cfergeau mentioned this issue Feb 26, 2020
Merged
cfergeau added a commit to cfergeau/crc that referenced this issue Feb 27, 2020
@cfergeau
Issue crc-org#1013: Check resolved IP in CheckCRCLocalDNSReachableFro…
5acc0a6 
…mHost

CheckCRCLocalDNSReachableFromHost checks that the api.crc.testing and
foo.apps-crc.testing hostnames can be resolved, but it does not check
this returns the IP of the VM. This commit adds an additional check
that the resolved IP matches the IP of the VM as this could help crc
detect some host misconfigurations early.

This resolves crc-org#1013
cfergeau added a commit to cfergeau/crc that referenced this issue Feb 27, 2020
@cfergeau
fixup! Issue crc-org#1013: Check resolved IP in CheckCRCLocalDNSReach…
4b2c24c 
…ableFromHost
cfergeau added a commit to cfergeau/crc that referenced this issue Feb 28, 2020
@cfergeau
Issue crc-org#1013: Check resolved IP in CheckCRCLocalDNSReachableFro…
06a4770 
…mHost

CheckCRCLocalDNSReachableFromHost checks that the api.crc.testing and
foo.apps-crc.testing hostnames can be resolved, but it does not check
this returns the IP of the VM. This commit adds an additional check
that the resolved IP matches the IP of the VM as this could help crc
detect some host misconfigurations early.

This resolves crc-org#1013
praveenkumar pushed a commit that referenced this issue Mar 2, 2020
@cfergeau @praveenkumar
Issue #1013: Check resolved IP in CheckCRCLocalDNSReachableFromHost
a41a692 
CheckCRCLocalDNSReachableFromHost checks that the api.crc.testing and
foo.apps-crc.testing hostnames can be resolved, but it does not check
this returns the IP of the VM. This commit adds an additional check
that the resolved IP matches the IP of the VM as this could help crc
detect some host misconfigurations early.

This resolves #1013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Issue #1013: Check resolved IP in CheckCRCLocalDNSReachableFromHost cfergeau/crc
1 participant
@cfergeau