Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add callback function to inform user if memory/cpu config set. #539

Closed
praveenkumar opened this issue Sep 5, 2019 · 0 comments · Fixed by #542
Closed

Add callback function to inform user if memory/cpu config set. #539

praveenkumar opened this issue Sep 5, 2019 · 0 comments · Fixed by #542

Comments

@praveenkumar
Copy link
Member

As of now we are not letting users know that if they set memory or cpu configs as part of config set they need to start a fresh instance to apply those configs.

Something we use to have in minishift side.

$  ./minishift config set memory 4096
No Minishift instance exists. New 'memory' setting will be applied on next 'minishift start'

$ ./minishift config set memory 4096
You currently have an existing Minishift instance. Changes to the 'memory' setting are only applied when a new Minishift instance is created.
To let the configuration changes take effect, you must delete the current instance with 'minishift delete' and then start a new one with 'minishift start'.
praveenkumar added a commit that referenced this issue Sep 6, 2019
Configs which required to provide a message to end user should
be considered using callback functions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant