Fix destination file for win/mac tray #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfergeau
reviewed
Jan 6, 2021
Extract function take embedded file name and destination filename to extract the file from the binary to destination file. We had bug till now in tray side where we are passing the destination folder instead destination file and extration fails. ``` DEBU Could not extract tray from crc executableCould not create '/var/folders/6q/9mnplh5s6wg__rrvzdv9nkp80000gn/T/crc094171414': open /var/folders/6q/9mnplh5s6wg__rrvzdv9nkp80000gn/T/crc094171414: is a directory ```
anjannath
approved these changes
Jan 7, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: anjannath, praveenkumar The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract function take embedded file name and destination filename to
extract the file from the binary to destination file. We had bug till
now in tray side where we are passing the destination folder instead
destination file and extration fails.