Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client connection revive #9

Closed
darkl opened this issue May 4, 2013 · 6 comments
Closed

Client connection revive #9

darkl opened this issue May 4, 2013 · 6 comments

Comments

@darkl
Copy link
Member

darkl commented May 4, 2013

When a client connection is lost, it should try to revive it.

@shanielh
Copy link

Isn't implemented yet?

@darkl
Copy link
Member Author

darkl commented Nov 21, 2013

Not implented yet. Note this is a WAMP client feature. You are welcome to write a pull request.

@shanielh
Copy link

Oh, I thought it's a client feature. We're good.

@alexandru-calinoiu
Copy link
Contributor

@darkl I might take a look at this, shall I send a PR on the on wamp1 or 2?

@darkl
Copy link
Member Author

darkl commented Jul 25, 2014

Hmmm,
The WAMPv1 and WAMPv2 client implementations are different (wampv2 branch also has WAMPv1 implementation, but its WAMPv2 client is implemented differently).

The reason I never implemented this is because in the wampv1 branch the interface for IWampConnection is ISubject which is an IObservable.
Due to rx guidelines, after an IObservable has sent OnError or OnCompleted, it should never send any further messages. This makes the revive feature problematic - since after an OnError or OnCompleted, the connection will try to reconnect and then send other messages to its observers.
I've changed the interface for IWampConnection in the wampv2 branch, so now it is no longer a ISubject and we won't break rx guidelines.

So if you're willing to work on this, please work on wampv2 branch. I guess you should work on the WAMPv1 client there, since WAMPv2 client is still in work in progress.

Thanks

@darkl
Copy link
Member Author

darkl commented Mar 19, 2015

Implemented for WAMPv2, see #60.

@darkl darkl closed this as completed Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants