Name generator #16
Merged
Name generator #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew-demb
suggested changes
Apr 22, 2021
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
andrew-demb
reviewed
Apr 22, 2021
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
andrew-demb
reviewed
Apr 22, 2021
# Conflicts: # src/Name/Generator/CommandNameGenerator.php
andrew-demb
suggested changes
Apr 23, 2021
| @@ -23,8 +23,8 @@ public function generate(): string | |||
| { | |||
| $queue = clone $this->queue; | |||
| while (false === $queue->isEmpty()) { | |||
| if ('' !== ($debugId = $queue->extract()->generate())) { | |||
| return $debugId; | |||
| if ('' !== ($name = $queue->extract()->generate())) { | |||
There was a problem hiding this comment.
Is it special behavior for name generators - if them return an empty string, then caller may think it is like a 'I cannot generate name, try another one'?
src/Resources/services.yml
Outdated
| jaeger.name.generator.chain: | ||
| class: Jaeger\Symfony\Name\Generator\NameGeneratorChain | ||
| arguments: | ||
| - '@spl.priority.queue' | ||
| jaeger.name.generator: | ||
| alias: 'jaeger.name.generator.chain' | ||
| jaeger.name.generator.shorten: |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
if ($config['name_generator']['max_length']) {
$loader->load('shorten.yml');
$container->setParameter('jaeger.name.max_length', $config['name_generator']['max_length']);
}Added this to the configuration parser + separate shorten.yml
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
Co-authored-by: Andrii Dembitskyi <andrew.dembitskiy@gmail.com>
|
Added some suggestions for PR - #17 UPD: fixed link to PR |
…oller only for null value
Name generator suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name generation is a feature that aims to limit number of operation in case routes are generated dynamically and may result in thousands of different operation names, although are handled by the same
controller::action