Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.8.0 - Guest Comments #15

Merged
merged 11 commits into from May 7, 2018
Merged

v0.8.0 - Guest Comments #15

merged 11 commits into from May 7, 2018

Conversation

code-with-sam
Copy link
Owner

@code-with-sam code-with-sam commented May 7, 2018

This PR adds the Guest Commenting functionality to Finally Comments.

Previously a user would need to sign in before being able to interact with the comments thread. Currently the wait time for a Steem signup can be up to 1-2weeks, this is unacceptable for a user who wants to just leave a quick comment on a blog post.

The guest comment allows a quick comment without needing auth. As these comments are not posted to the steem blockchain (the have no STEEM user associated) they are stored in a database. Incorporating steem/non-steem comments is a little tricky and means that replies to a guest comment from an authorised user still can not be posted to the blockchain (they will have no parent or context on the root post).

NEW

  • Guest Posting - UI/Routes/AJAX/Models/Database
  • Replying to Guest - ^

guest

reply

Updated

  • I was able to refactor parts of the comment template code so all actions STEEM, NON-STEEM and REPLY-TO-NON-STEEM can all use the same comment template function. In general there is still some work to do in documenting and refactoring to improve maintainability.

@code-with-sam code-with-sam merged commit eae12ac into master May 7, 2018
@Sambillingham Sambillingham deleted the v0.8.0 branch July 1, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants