Update node-playwright image #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/pictor/-/pipelines/1292348516 Status: Passed Job summariesdocs:previewDocumentation preview available at https://code0-tech.gitlab.io/-/development/telescopium/-/jobs/6861587793/artifacts/dist/index.html storybook:buildStorybook available at https://code0-tech.gitlab.io/-/development/pictor/-/jobs/6861571404/artifacts/storybook-static/index.html |
nicosammito
previously approved these changes
May 14, 2024
We did not specify a fixed playwright version which caused pipeline errors due to missing browser when the package-lock.json was recreated. The browsers were missing in the docker image, because the docker image contained older versions of the browsers. To prevent an accidental playwright update, the version is now pinned to a specific version and can be updated when updating the docker image to ensure the browser versions in the docker image and required browser versions by playwright stay in sync.
nicosammito
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did not specify a fixed playwright version
which caused pipeline errors due to missing
browser when the package-lock.json was recreated.
The browsers were missing in the docker image,
because the docker image contained older versions
of the browsers.
To prevent an accidental playwright update, the
version is now pinned to a specific version and
can be updated when updating the docker image to
ensure the browser versions in the docker image
and required browser versions by playwright stay
in sync.
This MR pins the playwright version and updates
the docker image to have matching browser versions.