Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/auth #129

Merged
merged 5 commits into from
Apr 11, 2024
Merged

Feat/auth #129

merged 5 commits into from
Apr 11, 2024

Conversation

nimit9
Copy link
Contributor

@nimit9 nimit9 commented Apr 4, 2024

Fixes: #127

  • Replaced firebase auth with next auth using google and github providers
  • Added Prisma Adapter to map user table with provider details

GoogleProvider({
clientId: process.env.GOOGLE_CLIENT_ID || "",
clientSecret: process.env.GOOGLE_CLIENT_SECRET || "",
allowDangerousEmailAccountLinking: true,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was giving an error OAuthAccountNotLinked, when logging in from google, logging out and again logging with github, this is the solution I find to avoid the error. Let me know if it's a known error to you @hkirat and if there is any other way to solve it.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its because - the gmail account is the same , so it gives error

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, correct

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can ignore for now

@bhutoria
Copy link
Contributor

@hkirat , can this be merged as early as possible, we can work on personalising user experience then.

@@ -10,13 +10,16 @@
"lint:fix": "eslint --fix ."
},
"dependencies": {
"@auth/prisma-adapter": "^1.5.2",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very smart decision using this

@hkirat hkirat merged commit a077d7e into code100x:main Apr 11, 2024
@hkirat
Copy link
Collaborator

hkirat commented Apr 11, 2024

/bounty $300

@hkirat
Copy link
Collaborator

hkirat commented Apr 11, 2024

thanku for ur contirbution
Too much pressure so many people watching
would;'ve probaboy given 250 if we were off stream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace firebase auth with nextauth
4 participants