Skip to content

Commit

Permalink
rename delete_included_users... methods (#415)
Browse files Browse the repository at this point in the history
  • Loading branch information
tora-kozic committed Apr 21, 2022
1 parent 3756575 commit 3164037
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 8 deletions.
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ how a consumer would use the library (e.g. adding unit tests, updating documenta
- `get_all_included_users()`
- `add_included_users_by_watchlist_id()`
- `add_included_users_by_watchlist_type()`
- `delete_included_users_by_watchlist_id()`
- `delete_included_users_by_watchlist_type()`
- `remove_included_users_by_watchlist_id()`
- `remove_included_users_by_watchlist_type()`
- `get_all_watchlist_members()`
- `get_watchlist_member()`
- `UserRiskProfile` client includes the following methods:
Expand Down
4 changes: 2 additions & 2 deletions src/py42/clients/watchlists.py
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ def add_included_users_by_watchlist_type(self, user_ids, watchlist_type):
user_ids, watchlist_type
)

def delete_included_users_by_watchlist_id(self, user_ids, watchlist_id):
def remove_included_users_by_watchlist_id(self, user_ids, watchlist_id):
"""Remove users that are explicitly included on a watchlist.
Args:
Expand All @@ -129,7 +129,7 @@ def delete_included_users_by_watchlist_id(self, user_ids, watchlist_id):
user_ids, watchlist_id
)

def delete_included_users_by_watchlist_type(self, user_ids, watchlist_type):
def remove_included_users_by_watchlist_type(self, user_ids, watchlist_type):
"""Remove users that are explicitly included on a watchlist.
Args:
Expand Down
8 changes: 4 additions & 4 deletions tests/clients/test_watchlists.py
Original file line number Diff line number Diff line change
Expand Up @@ -74,22 +74,22 @@ def test_add_included_users_by_watchlist_tyoe_calls_service_with_expected_params
user_ids, WATCHLIST_TYPE
)

def test_delete_included_users_by_watchlist_id_calls_service_with_expected_params(
def test_remove_included_users_by_watchlist_id_calls_service_with_expected_params(
self, mock_watchlists_service
):
watchlists_client = WatchlistsClient(mock_watchlists_service)
user_ids = ["1a", "2b", "3c"]
watchlists_client.delete_included_users_by_watchlist_id(user_ids, WATCHLIST_ID)
watchlists_client.remove_included_users_by_watchlist_id(user_ids, WATCHLIST_ID)
mock_watchlists_service.delete_included_users_by_watchlist_id.assert_called_once_with(
user_ids, WATCHLIST_ID
)

def test_delete_included_users_by_watchlist_tyoe_calls_service_with_expected_params(
def test_remove_included_users_by_watchlist_tyoe_calls_service_with_expected_params(
self, mock_watchlists_service
):
watchlists_client = WatchlistsClient(mock_watchlists_service)
user_ids = ["1a", "2b", "3c"]
watchlists_client.delete_included_users_by_watchlist_type(
watchlists_client.remove_included_users_by_watchlist_type(
user_ids, WATCHLIST_TYPE
)
mock_watchlists_service.delete_included_users_by_watchlist_type.assert_called_once_with(
Expand Down

0 comments on commit 3164037

Please sign in to comment.