remove detectionlists, high-risk-employee, and departing-employee cli… #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tora-kozic
force-pushed
the
chore/remove-ecm-apis
branch
from
b0487fd
to
0b931c1
Compare
johnsonjben
approved these changes
Aug 8, 2023
| @@ -8,6 +8,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
| The intended audience of this file is for py42 consumers -- as such, changes that don't affect | |||
| how a consumer would use the library (e.g. adding unit tests, updating documentation, etc) are not captured here. | |||
|
|
|||
| ## 1.27.0 - 2023-08-04 | |||
There was a problem hiding this comment.
We removed APIs in this update, I understand they were already deprecated, but should this be a major version bump?
There was a problem hiding this comment.
My thought was no because the backend doesn't exist anyway, so updating versions or pinning an old version would have no effect.
There was a problem hiding this comment.
Honestly its closer to a bugfix chore imo
|
There's one more reference to detection lists in docs/userguides/basics.md. |
jdullum
approved these changes
Aug 8, 2023
src/py42/sdk/__init__.py
Outdated
| cases_conn = Connection.from_microservice_key(kv_service, cases_key, auth=main_auth) | ||
| trusted_activities_conn = Connection.from_microservice_key( | ||
| kv_service, trusted_activities_key, auth=main_auth | ||
| ) | ||
| watchlists_conn = Connection.from_microservice_key( | ||
| kv_service, watchlists_key, auth=main_auth | ||
| ) | ||
| userriskprofile_svc = UserRiskProfileService(watchlists_conn) |
src/py42/sdk/__init__.py
Outdated
| cases_conn = Connection.from_microservice_key(kv_service, cases_key, auth=main_auth) | ||
| trusted_activities_conn = Connection.from_microservice_key( | ||
| kv_service, trusted_activities_key, auth=main_auth | ||
| ) | ||
| watchlists_conn = Connection.from_microservice_key( | ||
| kv_service, watchlists_key, auth=main_auth | ||
| ) | ||
| userriskprofile_svc = UserRiskProfileService(watchlists_conn) |
tests/services/test_alert_rules.py
Outdated
| mocker, "{}" | ||
| ) | ||
| return detection_list_user_service | ||
| def mock_user_service(mocker): |
There was a problem hiding this comment.
Consider mock_user_risk_profile_service
tora-kozic
force-pushed
the
chore/remove-ecm-apis
branch
from
d79d741
to
d5bf66f
Compare
tora-kozic
force-pushed
the
chore/remove-ecm-apis
branch
from
d5bf66f
to
07138fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.