Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce code smells for the framework quality improvement #1006

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Reduce code smells for the framework quality improvement #1006

wants to merge 15 commits into from

Commits on Mar 23, 2021

  1. Add missing @deprecated annotation

    @JeanDeboutGat
    JeanDeboutGat committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    e63ee73 View commit details
    Browse the repository at this point in the history

  2. Add missing @deprecated Javadoc tag

    @JeanDeboutGat
    JeanDeboutGat committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    6cf9278 View commit details
    Browse the repository at this point in the history

  3. Optimize the expression

    @JeanDeboutGat
    JeanDeboutGat committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    647139e View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2021

  1. Rename constant names to match regular expressions and comply a namin… 

    …g convention
    @JeanDeboutGat
    JeanDeboutGat committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    c942d7c View commit details
    Browse the repository at this point in the history

  2. Define the constants instead of duplicating a litteral 3 times.

    @JeanDeboutGat
    JeanDeboutGat committed Mar 30, 2021
    Configuration menu
    Copy the full SHA
    c287de7 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2021

  1. Add up and completion of javadoc

    @JeanDeboutGat
    JeanDeboutGat committed Apr 4, 2021
    Configuration menu
    Copy the full SHA
    203d823 View commit details
    Browse the repository at this point in the history

Commits on Apr 5, 2021

  1. Improve code's readability by applying modifiers standard order

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    4e77739 View commit details
    Browse the repository at this point in the history

  2. Improve code perfomance (time complexity) and readability

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    5b80d66 View commit details
    Browse the repository at this point in the history

  3. Reduce nullity test complexity by returning empty array instead of null

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    6e8c858 View commit details
    Browse the repository at this point in the history

  4. Refactor variables names for code explicitness

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    1ec13ac View commit details
    Browse the repository at this point in the history

  5. Refactor on catch multiple exceptions for better readability

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    971ca5b View commit details
    Browse the repository at this point in the history

  6. Break down method goal into small pieces for code simplicity

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    5a3f9a8 View commit details
    Browse the repository at this point in the history

  7. Refactor on unnecessary boolean expression

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    c87464e View commit details
    Browse the repository at this point in the history

  8. Make constructors visible to the only members concerned

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    943a4db View commit details
    Browse the repository at this point in the history

  9. Add @OverRide notation for compiler warning and code readability reason

    @JeanDeboutGat
    JeanDeboutGat committed Apr 5, 2021
    Configuration menu
    Copy the full SHA
    461e29a View commit details
    Browse the repository at this point in the history