Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

site.data.path references are broken in some places #9

Closed
phette23 opened this issue Sep 14, 2016 · 3 comments · Fixed by #29
Closed

site.data.path references are broken in some places #9

phette23 opened this issue Sep 14, 2016 · 3 comments · Fixed by #29
Assignees

Comments

@phette23
Copy link
Member

It looks like in the cleanup work the entirely of the _data/path.yml file was wiped out—it now contains just a single reference to the site root '/'. That actually works a lot of places but I noticed it broke some footer links:

<li class="list-item tci"><a href="{{ site.data.path }}schedule">Schedule</a></li>
<li class="list-item tci"><a href="{{ site.data.path }}attend.html">Attend</a></li>

in this instance, the "Schedule" link is fine since it gets redirected to the directory index but "attend.html" doesn't exist anymore and breaks. I'll send a PR referencing this & fixing the footer links but I wanted to point out the larger issue because ``{{site.data.path}}` references are littered throughout the code base and probably nonfunctional in a some other places.

joshuago78 added a commit that referenced this issue Sep 14, 2016
fix hrefs in footer links, ref #9
@queryluke
Copy link
Contributor

@phette23 If we're always going to have an updated cname, there is no reason to keep {{site.data.path}}, it was a stop-gap while we didn't have the 2016 subdomain last year

Clear it out or fix the broken ones?

@phette23
Copy link
Member Author

I think it's a straight search-and-replace with "/" so I'd vote to clear out just to simplify things that minimal amount. I'm happy to do it.

@phette23 phette23 self-assigned this Oct 13, 2016
@queryluke
Copy link
Contributor

I'm for it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants