Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header says we're an online conference after the date #42

Closed
yarnetsky opened this issue Nov 11, 2021 · 3 comments
Closed

Header says we're an online conference after the date #42

yarnetsky opened this issue Nov 11, 2021 · 3 comments

Comments

@yarnetsky
Copy link
Contributor

Shall we pull the word "Online" in the header and leave just the date as was prior practice (2020 and before)?

If we're going to be hybrid then "live and online" might be worth noting, but otherwise saying online might mislead.

@dzoladz
Copy link
Member

dzoladz commented Nov 12, 2021

I'm going to merge some code to remove the "Online" designation in the jumbotron as a quick fix. This is related to both #8, #41, and some less-than-ideal implementation for last year's online-only conference.

@phette23
Copy link
Member

phette23 commented Dec 3, 2021

So if I understand right this refers to the jumbotron include: https://github.com/code4lib/2022.code4lib.org/blob/main/_includes/homepage/jumbotron.html#L21-L23

The if site.data.conf.venue.name != nil (possibly added by Derek's commit above?) check should ensure that this doesn't display except when the conference is actually online. So I think we can close this one but will wait for Jerry to confirm.

@dzoladz
Copy link
Member

dzoladz commented Feb 9, 2022

No comments or activity for 2 months. Closing this one.

@dzoladz dzoladz closed this as completed Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants