Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace URI with addressable #26

Closed
atomotic opened this issue Nov 19, 2012 · 1 comment
Closed

replace URI with addressable #26

atomotic opened this issue Nov 19, 2012 · 1 comment

Comments

@atomotic
Copy link
Contributor

what do you think about replacing URI with addressable?
often i deal with domain containing "_" (that violates RFC 1034 supported by URI)

https://github.com/code4lib/ruby-oai/blob/master/lib/oai/client.rb#L85

require 'addressable/uri'
@base = Addressable::URI.parse base_url

ciao

@barmintor
Copy link
Collaborator

Thank you for this report - I'm sorry it was never addressed.

Per https://bugs.ruby-lang.org/issues/8241, Ruby's core URI parse has supported this behavior since Ruby 2.2, and this library currently requires Ruby >= 2.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants