Allow for passing until param. #56
Conversation
|
👍 Looks like a pretty straightforward and useful addition. |
|
I am now a committer/owner of this project. Happy to merge this if you are still interested -- but it probably needs a test? |
|
One more try, I am a committer/owner, and could find some time to review/merge this is you are still interested, but I think it probably needs a test to be merged. If I don't hear, I may close this as outdated/abandoned, to clean things up. @dkinzer ? |
|
@jrochkind I haven't been the official developer on the harvester for a while now; and the other developer started using python for this step. However, I am back on that project now. And I do believe this is still useful. If I start using this gem I again, it would definitely come in handy. Thanks @jrochkind! |
|
In order to be merged, I think we need a test of some kind. Doesn't need to be perfect, but some kind of test that fails without this code there. Are you interested in adding a test, @dkinzer or @bibliotechy ? I'm definitely in minimal caretaker mode, don't have time to do much code that isn't directly related to my needs, just trying to do a bit of cleanup while I'm stopping in. |
- move DIRECTORY_LAYOUT global to OAI::Harvester::Harvest class and make configurable - delegate record parsing to ListRecords response in harvester - do nothing with harvested tempfile if no directory storage is configured - use application exceptions in harvester
This commit allows the client to harvest a specific range not limited to from until now.
- harvest_time is expected to be a Time, not a String
barmintor
force-pushed
the
allow-harvest-with-until-param
branch
from
29d9cf3
to
af6fa62
Compare
|
Ok, I've added a test rig for OAI::Harvester and a test case for this change. It was surprisingly involved, but I think this captures what @dkinzer was going for. |
This commit allows the client to harvest a specific range not limited to
from until now.
Addendum: