Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont try to localize slug #1107

Merged
merged 1 commit into from Mar 30, 2023
Merged

Conversation

joshreisner
Copy link
Contributor

fixes #1106

to recreate this problem locally, set the website language to russian, and save permalinks. you will start seeing 404s on your meetings page.

then pull this PR down, you will start seeing the page showing up again at /meetings (after resaving permalinks)

users can still customize the slug to something else with the normal method of setting $tsml_slug in their functions.php - this change will just stop it trying to localize it for them.

@joshreisner joshreisner requested a review from a team March 29, 2023 02:18
@joshreisner joshreisner self-assigned this Mar 29, 2023
Copy link
Collaborator

@kiyote33 kiyote33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@joshreisner joshreisner merged commit 71a8bb6 into main Mar 30, 2023
kiyote33 pushed a commit that referenced this pull request May 15, 2023
@joshreisner joshreisner deleted the 1106-meetings-page-404-when-language branch August 25, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

meetings page 404 when language is localized
2 participants