1337 add a meetings block for wp block themes #1383
Conversation
…files - Removed @tinypixelco/laravel-mix-wp-blocks & @wordpress/dependency-extraction-webpack-plugin dependencies - Added @wordpress/scripts dependency - Moveed render.php to block directory (best practice) - Set .gitignore, webpack.mix.js & mix-manifest.json back to original content
| }, | ||
| "message": { | ||
| "type": "string", | ||
| "default": "There are no upcoming meetings today. Please check back tomorrow." |
There was a problem hiding this comment.
is this text accurate? this seems like it applies more to the Upcoming Meetings widget?
if this block embeds TSML UI it should probably say something like "TSML UI could not be embedded" - not sure what scenario this wouldn't show…
There was a problem hiding this comment.
This is a config value the user can change in the block settings when there are no upcoming meetings listed. It only shows up in the block config for that block, but needs a starting value.
There was a problem hiding this comment.
This is where that setting shows up.
| {label: 'Meetings UI', value: 'tsml_ui'}, | ||
| {label: 'Next Meetings', value: 'tsml_next_meetings'}, | ||
| {label: 'Types List', value: 'tsml_types_list'}, | ||
| {label: 'Regions List', value: 'tsml_regions_list'} |
There was a problem hiding this comment.
do these options show up anywhere? i don't see them in the block editor but i might be looking in the wrong place?
There was a problem hiding this comment.
Yes, if you add the "Meetings" block, and click on the block, that setting should show up as a dropdown.
There was a problem hiding this comment.
left a few minor questions
this seems great, i was able to embed the block
i then struggled mightily trying to get it to go wider in 2024 and couldn't, but i don't think that can be helped by us, right? there's no way to make it easier to go wider?
it would be great if we could make a loom or other short screencast video showing how to make the block wider and link it from the description, but that can be in a future PR
|
The align toolbar is where you set the width/alignment. I agree, a screenshot at the very least or a short vid might be helpful. I think people who are comfortable with the block editor might know where to look. I am going to push one more commit to the PR to set .gitignore and webpack.mix.js back to the original files. It looks like my IDE converted tabs to spaces. 
|
I think we should. What I did, eliminates the extra files generated by Mix, but adds a build step so we may want to discuss that in addition to whatever you'd like to discuss. |
|
maybe i'm trying to add it to the wrong place, but i don't see width options on the block 
nor on the columns parent 
|
- Use tabs insotead of spaces in block.json for consistency
|
What theme are you using? 2024? I think themes have to declare support for those options. It may be that we can declare that support in TSML. I can check. |
|
I didn't realize I should have added support for alignWide in the block.json. Hopefully the latest commit fixes the issue with the alignment toolbar. |
|
looks like dependabot's pr made a conflict in i'm not seeing alignment options, but perhaps i'm doing it wrong? maybe we could meet at some point and you could show me how to do it? also should i still be seeing "select a block type" on the right? |
Renders all TSML shortcodes as Gutenberg blocks.
Currently, this PR generates 2 files in the plugin root when running
npx mix --productionornpx mix watch(undefined.js & undefined.asset.php). These are unnecessary, and were added to the .gitignore as a stop gap, but this is not ideal. Hoping to get some assistance on finding a better way to compile assets or to fix the anomalous files being generated.`