Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wp data source updates only #1398

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Conversation

kiyote33
Copy link
Collaborator

@kiyote33 kiyote33 commented Mar 24, 2024

Branched Wp change detection updates #1282 (March 24. 2024). Resolving several issues from that PR. Specifically:

  1. Store the remote slug in a meta field prior to import transformation so it can be used for comparison when the import slug / database slug match fails. This will replace the concatenated meeting day/time/name lookup. Resolves accuracy issue where occasional meeting changes were missed due to the forced slug mutation by WordPress when other imports have already registered the remote slug.
  2. Modify the comparison code checking for changes in the formatted_address field which may get mutated by Google. Only notify end user when the incoming address differs from the value stored in the new meta field.
  3. Refactor function call (tsml_get_import_changes_only) to output to a list instead of passing variables byRef. This is felt to be cleaner.
  4. Minor tweaks: - [Eliminate translation strings from the code when in debug mode. Remove variables from translation strings. Cleanup non-DRY code blocks. Removal of dead code...` . Drop slug comparison code which is redundant. Review & cleanup readme.txt to sync with these changes. Rename tsml_do_differential_comparison() to tsml_compare_meetings() and drop variables no longer needed. ]

kiyote33 and others added 30 commits December 18, 2023 13:44
New feature: Change Detection Updating. See #1075 for details.
…rds. Fix bug related to feed import not matching up with the correct db record, which happens when non-unique meeting names are entered during multiple feed imports.
… commented out code. Standardized comment style. Removed unused variables. Made differential change detection (full matching) the default method. Modified alert messages, keeping them simple and short. Added support for Google Sheets importing. Changed algorithm for nightly scans to match the code used for data source refreshes.
…e the same method for nightly scan and when pressing the Refresh button. $tsml_debug now can be toggled in child theme functions.php. Cleanup dead code.
Fixed 'inactive' and a few other minor bugs.
Removed verbose alerts and standardized comments.
…te space diff generated by PSR-12 application. Few other minor bugs fixed.
…on Differential code, cloning parts of SetBuffer importer code to ensure proper comparison between db and import.
This reverts commit 1ea99bb, reversing
changes made to 0f13bac.
… phone and region comparisons. Added code to handle unknown 'updated' date format. Extracted most of tsml_import_buffer_set code to separate function to support Differential Code check as well as nornal Import processing.
…ak differential comparison refactoring. Removed incremental comparison updated code.
Changes not pertinent to core work
…rom the ReadMe. Fix display link bug in Change Report email when New Meeting is added.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants