Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix - Dropdown update #60

Merged
merged 5 commits into from
Apr 9, 2024
Merged

Conversation

leo95oliveira
Copy link
Contributor

This PR contains changes to allow the components library dropdown component to detect clicks outside of it and close automatically (under the condition that the openOnHover prop is not set to true)

Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 6:07pm

Copy link
Contributor

@matthewcsimpson matthewcsimpson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can dig it. Tested in Storybook & works as advertised.

@leo95oliveira leo95oliveira merged commit a3b18f6 into develop Apr 9, 2024
4 checks passed
@leo95oliveira leo95oliveira deleted the leo95oliveira/dropdown-update branch April 9, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants