Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create tables and initial data inserts in a single file #78

Merged
merged 4 commits into from
Feb 23, 2019

Conversation

lrdTnc
Copy link
Contributor

@lrdTnc lrdTnc commented Jan 26, 2019

Moved all the existing sql in one place.

#77

Copy link
Contributor

@RaduCStefanescu RaduCStefanescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the table names defined in InitializeDB script.
All over the API usage we use capitalisation for table names and in the script these are all lower case. This will create issues for deployments.
Also, please check the 'id' column. The API is also using this column capitalised ('Id'), please change this as well.

@lrdTnc
Copy link
Contributor Author

lrdTnc commented Feb 22, 2019

Hello @RaduCStefanescu ,
will do!

Could you please provide the mysql version that is used on the deployment server?
(I will use forward engineering from mysql-workbench which is able to generate DDL Scripts for a specific mysql version)

I noticed that the stored procedures use as input in many cases varchar(1000). Will also double check in the table column definitions to make sure everything's fine.

@RaduCStefanescu RaduCStefanescu merged commit 53206b9 into code4romania:develop Feb 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants