Add group users limit verification #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Laxynium
requested review from
aniri,
decembrya,
idormenco and
Puiu
as code owners
Laxynium
force-pushed
the
feature/group-users-limit#98
branch
from
d20b333
to
2a8b5f0
Compare
decembrya
requested changes
Oct 6, 2021
|
You're right about the bug, nice catch :). Added #116 |
decembrya
approved these changes
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does it fix?
Closes #98
How has it been tested?
I have added new test to
AcceptGroupInviteValidatormaking sure that user cannot accept invitation when the limit is exceeded.I am not sure, but I think there is bug in
DeUrgenta.Group.Api.GroupsConfig. PropertySectionNamehas value"Groups"whereas inDeUrgenta.Api.appsettings.jsonsection is named"Group"