Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup and yaml builds #229

Merged
merged 7 commits into from
Jul 25, 2020
Merged

Cleanup and yaml builds #229

merged 7 commits into from
Jul 25, 2020

Conversation

bvizureanu
Copy link
Member

closes #228
closes #152

aniri
aniri reviewed Mar 1, 2020
View reviewed changes
Copy link
Member

@aniri aniri left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bvizureanu why was the file vote_monitor_diagram.png removed? the image appears in the readme.

@bvizureanu
Copy link
Member Author

@bvizureanu why was the file vote_monitor_diagram.png removed? the image appears in the readme.

well I saw that it's being referenced in other repos as well and it could live in a storage/wiki somewhere rather than directly in each repo.
+git doesn't necessarily like binary files

@aniri
Copy link
Member

aniri commented Mar 3, 2020

@bvizureanu why was the file vote_monitor_diagram.png removed? the image appears in the readme.

well I saw that it's being referenced in other repos as well and it could live in a storage/wiki somewhere rather than directly in each repo.
+git doesn't necessarily like binary files

ok :) let's move it then and update the readme from this repo :)

@aniri aniri mentioned this pull request Jun 1, 2020
Closed
aniri
aniri previously approved these changes Jul 25, 2020
View reviewed changes
@aniri aniri changed the base branch from master to develop July 25, 2020 19:52
@aniri aniri dismissed their stale review July 25, 2020 19:52

The base branch was changed.

@aniri aniri requested a review from idormenco as a code owner July 25, 2020 19:52
@aniri aniri self-requested a review July 25, 2020 19:52
@aniri aniri merged commit 05dff2c into develop Jul 25, 2020
@bvizureanu bvizureanu deleted the cleanup branch July 26, 2020 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aniri aniri aniri approved these changes

@bogdanconstantinescu bogdanconstantinescu Awaiting requested review from bogdanconstantinescu bogdanconstantinescu is a code owner

@idormenco idormenco Awaiting requested review from idormenco idormenco is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build is broken Remove api from current repo
2 participants
@bvizureanu @aniri