[bug] Map position should stay fixed when changing filters

[tudoramariei]

Currently, when a map filter is selected the map position changes to another place.

The map should stay fixed when changing filters and position should be changed only by the user by panning, zooming, and selecting a marker.

Current behaviour:

[GabrielMajeri]

The reason why this is happening is because of these lines of code:

seismic-risc/client/src/components/HereMapInteractive.js

Lines 56 to 68 in 1616f56

	if (points.length > 1) {
	const latitudes = points.map((p) => p.lat);
	const longitudes = points.map((p) => p.lng);
	const bounds = new H.geo.Rect(
	Math.max(...latitudes),
	Math.min(...longitudes),
	Math.min(...latitudes),
	Math.max(...longitudes),
	);
	currentMap.getViewModel().setLookAtData({ bounds, zoom: 10 }, true);
	} else {
	currentMap.getViewModel().setLookAtData({ zoom: 10 }, true);
	}

They calculate the bounds of the new points, and tries to reposition the map so that it contains them all.

We could remove the code and this bug would be fixed, but are we sure we want to completely lose this behavior?

[tudoramariei]

@GabrielMajeri sorry for the late response; I only just managed to test out the changes locally

I feel the current behaviour is flawed. That's because this feature does position the map at the centre of all the markers but it doesn't change the zoom level
e.g. if I add a building in Iasi, the starting position would be somewhere above Focsani and I can't really see any marker on the map 😒

It would be great if the map self-centred to show all markers when being opened for the first time and I would like a show me an overview of the map button
At the same time, I want the map to stay put when switching filters. If someone wants to see more details of a specific location they wouldn't want the map to just switch positions with every filter change

[tudoramariei]

The PR I made is rather a POC. While not the best solution, it fixes the issue. Maybe we can find a better solution, though 🤔

[GabrielMajeri]

The PR does solve this bug as is described. For your idea with a show me an overview of the map button, how is the button supposed to look like? We could add it as a regular HTML button, or implement it as a custom map UI button.

[tudoramariei]

I'm waiting for some answers from UX to see if we actually do want a button. If not, we'll just kill the auto-centring feature of the map and call it a day.
So no sure answer here yet.

[myshy93]

why this is not closed?

[tudoramariei]

Because it hasn't been fixed yet 😅
Closed it since I just didn't have the time to check how the old changes would've fit with the new map

[vladplesu]

Hello, I can take this one if it`s still an issue.