Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/899 update client requirements #909

Merged

Conversation

alinaMihai
Copy link
Contributor

This PR updates the package.json dependencies and handles the breaking changes caused by the following dependency major upgrades:

Notes:

  • I have tried upgrading to react-router v6, but there were some issues found in the tests related to useMatch, and I reverted the version upgrade
  • I have also noticed the translations not being properly matched when upgrading to lingui v4, which I didn't know how to fix, and I reverted the version upgrade as well.

I recommend tackling the major dependency upgrades for React Router and Lingui in separate tasks to minimize the risks involved in the migration process.

@vercel
Copy link

vercel bot commented May 27, 2023

@alinaMihai is attempting to deploy a commit to the Code for Romania Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented May 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
seismic-risc ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 29, 2023 7:15am

Copy link
Member

@tudoramariei tudoramariei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the changes 🚀

Copy link
Member

@tudoramariei tudoramariei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for all the changes 🚀

@tudoramariei tudoramariei merged commit 982cf6c into code4romania:develop May 29, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[front-end] Update client requirements
2 participants