Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to disable shortcut detection #40

Closed
jcdickinson opened this issue Feb 23, 2012 · 4 comments
Closed

Option to disable shortcut detection #40

jcdickinson opened this issue Feb 23, 2012 · 4 comments

Comments

@jcdickinson
Copy link

Shortcut detection is severely hindering my ability to demonstrate my keyboard ninja skills.

@JakeGinnivan
Copy link
Member

Could you explain this one a little more. Our original intentions for Carnac was to overlay shortcuts (mainly) for presentations so people can learn/understand what we are doing.
You seem to want a opposite behavior, so more information about why would be useful

@jcdickinson
Copy link
Author

Sorry, work has just been absolutely insane since I last had a chance to work on this stuff.

The original problem was that SPACE was displaying as " ". This lead me to believe that the actual keys were being eaten when I hit CTRL+SPACE in Visual Studio (due to shortcut replacement) because it displayed as "CTRL + [Complete Member]". The actual problem was that space didn't have a special key replacement, which I addressed in my second PR (replace with with "Space" when a modifier is being held down): but I decided that some people might want to disable the shortcut detection for some reason: so it was worth leaving in.

@JakeGinnivan
Copy link
Member

I have used some of the ideas in another PR fixing the space issue you talked about, and put shortcuts only mode in.

Maybe open up a discussion issue for the keys only mode to get some feedback on the idea.

I recall another simplification of the special keys in your PR. Maybe you could do another pr with just that change.

Thanks for the PR.

Sent from my Windows Phone


From: Jonathan Dickinson
Sent: 27/03/2012 5:10 PM
To: Jake Ginnivan
Subject: Re: [carnac] Option to disable shortcut detection (#40)

Sorry, work has just been absolutely insane since I last had a chance to work on this stuff.

The original problem was that SPACE was displaying as " ". This lead me to believe that the actual keys were being eaten when I hit CTRL+SPACE in Visual Studio (due to shortcut replacement) because it displayed as "CTRL + [Complete Member]". The actual problem was that space didn't have a special key replacement, which I addressed in my second PR (replace with with "Space" when a modifier is being held down): but I decided that some people might want to disable the shortcut detection for some reason: so it was worth leaving in.


Reply to this email directly or view it on GitHub:
#40 (comment)

@jcdickinson
Copy link
Author

Sure I'll try when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants