Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private Loadbalancers Whitelist #447

Merged
merged 9 commits into from
Apr 3, 2019

Conversation

aballman
Copy link
Contributor

@aballman aballman commented Apr 3, 2019

  • Allows Private/Office type loadbalancers to augment their whitelisted IP ranges

@aballman aballman added P/Medium Priority: Medium S/Review Status: Please review labels Apr 3, 2019
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #447 into master will decrease coverage by 0.01%.
The diff coverage is 75%.

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   58.04%   58.03%   -0.02%     
==========================================
  Files          56       56              
  Lines        5759     5767       +8     
==========================================
+ Hits         3343     3347       +4     
- Misses       2076     2080       +4     
  Partials      340      340

@drshrey
Copy link
Contributor

drshrey commented Apr 3, 2019

@aballman looks good, can we add tests for this?

@aballman
Copy link
Contributor Author

aballman commented Apr 3, 2019

@aballman looks good, can we add tests for this?

@drshrey No, not really. I've added the artifact here just to increase the test coverage so it's not decreasing the coverage. But testing load balancers / services isn't totally possible.

@aballman aballman merged commit f8a73d7 into master Apr 3, 2019
@aballman aballman deleted the andrew/private-loadbalancers-whitelist branch April 3, 2019 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P/Medium Priority: Medium S/Review Status: Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants