Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: add unique ids in postgresql database plugin and response event structure #451

Merged
merged 10 commits into from
Apr 25, 2019

Conversation

drshrey
Copy link
Contributor

@drshrey drshrey commented Apr 24, 2019

Fixes:

  • postgresql plugin to use a working format for returning artifacts
  • including the database plugin inside main.go
  • unique ids for postgres DB names and users to allow multiple db installations for one project

Future Improvements:

@drshrey drshrey changed the title Add underscore for database plugin Add underscore statement for database plugin Apr 24, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #451 into master will decrease coverage by 0.05%.
The diff coverage is 67.56%.

@@            Coverage Diff             @@
##           master     #451      +/-   ##
==========================================
- Coverage   58.07%   58.02%   -0.06%     
==========================================
  Files          56       56              
  Lines        5799     5820      +21     
==========================================
+ Hits         3368     3377       +9     
- Misses       2090     2096       +6     
- Partials      341      347       +6

@aballman
Copy link
Contributor

remove spew

@drshrey drshrey added the S/In Progress Status: In Progress label Apr 24, 2019
@drshrey drshrey force-pushed the shreyas/add-database-statement branch from b9122f5 to e7b63aa Compare April 24, 2019 19:20
@drshrey drshrey changed the title Add underscore statement for database plugin Fix: add unique ids in postgresql database plugin and response event structure Apr 24, 2019
@drshrey drshrey added S/Review Status: Please review and removed S/In Progress Status: In Progress labels Apr 24, 2019
@drshrey drshrey merged commit 950bfdd into master Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S/Review Status: Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants