KongIngress Cluster IP Fix #452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #452 +/- ##
==========================================
- Coverage 58.11% 58.07% -0.04%
==========================================
Files 56 56
Lines 5789 5799 +10
==========================================
+ Hits 3364 3368 +4
- Misses 2084 2090 +6
Partials 341 341 |
aballman
previously approved these changes
Apr 24, 2019
aballman
previously approved these changes
Apr 24, 2019
aballman
approved these changes
Apr 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exit kong ingress create code early for clusterip types.
Currently the kong API code executes when creating a "clusterip" type, which should not happen. This returns a success message early, preventing this from happening.