Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dave/labels in redis #491

Closed
wants to merge 12 commits into from
Closed

Dave/labels in redis #491

wants to merge 12 commits into from

Conversation

davechan813
Copy link
Collaborator

@davechan813 davechan813 commented Jul 2, 2019

Try to fix #490. Changed functions signatures to pass/return two strings. Added the project name as one of the label for Redis deployment and pods.

dave-chen% kubectl get pods -n test --show-labels 
NAME                                              READY   STATUS    RESTARTS   AGE   LABELS
developmen-codeamp-pa-efbbde49-5998bdcc8b-wss9h   1/1     Running   0          15m   app=developmen-codeamp-pa-efbbde49,pod-template-hash=5998bdcc8b,projectName=codeamp-panel
dave-chen% kubectl get deploy -n test --show-labels 
NAME                             READY   UP-TO-DATE   AVAILABLE   AGE   LABELS
developmen-codeamp-pa-efbbde49   1/1     1            1           14m   app=developmen-codeamp-pa-efbbde49,projectName=codeamp-panel

@codecov
Copy link

codecov bot commented Jul 2, 2019

Codecov Report

Merging #491 into master will increase coverage by 0.08%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##           master     #491      +/-   ##
==========================================
+ Coverage   50.48%   50.57%   +0.08%     
==========================================
  Files          74       74              
  Lines        8378     8384       +6     
==========================================
+ Hits         4230     4240      +10     
+ Misses       3637     3633       -4     
  Partials      511      511

@davechan813 davechan813 added the S/Review Status: Please review label Jul 2, 2019
@davechan813 davechan813 requested a review from drshrey July 8, 2019 18:33
@aballman
Copy link
Contributor

Is this the right PR @davechan813? I don't see the labels being updated, and there's a lot of updates to unrelated tests.

@davechan813 davechan813 deleted the dave/labels-in-redis branch July 16, 2019 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S/Review Status: Please review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add labels to redis deployment to know which project is using it
2 participants