Check for pod restarts on deploy #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aballman
commented
Aug 14, 2019
aballman
commented
- Allows a budget of 1/4 of the pods requested worth of restarts before marking the build as failed.
added 6 commits
July 22, 2019 14:58
…Proceed with unwind logic in this case.
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
=========================================
+ Coverage 50.16% 50.2% +0.03%
=========================================
Files 75 75
Lines 8703 8729 +26
=========================================
+ Hits 4366 4382 +16
- Misses 3788 3793 +5
- Partials 549 554 +5 |
amoskyler
approved these changes
Aug 14, 2019
drshrey
approved these changes
Aug 14, 2019
| totalPodsForDeployment := len(allPods.Items) | ||
| totalPodRestarts := 0 | ||
|
|
||
| allowedPodRestartsRatio := 0.25 |
There was a problem hiding this comment.
Can we have a comment for this? Why 0.25?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.