Health probes #206
Merged
Health probes #206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If any of the options in Advanced Configurations are filled, we should have the dropdowns auto-opened, so the person is aware it's not empty. |
|
I can add auto open in a secondary PR |
amoskyler
commented
Jul 20, 2018
|
|
||
|
|
||
|
|
||
| {/* <Grid item xs={12}> */} |
There was a problem hiding this comment.
I will remove this huge comment block.
|
@amoskyler According to the kubernetes docs (https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/), |
|
The default values are handled in kubernetes. The zero is simply to
represent an empty setting.
On Jul 20, 2018 11:25 AM, "Shreyas Jaganmohan" <notifications@github.com> wrote:
@amoskyler <https://github.com/amoskyler> According to the kubernetes docs (
https://kubernetes.io/docs/tasks/configure-pod-container/configure-liveness-readiness-probes/),
successThresholds and failureThresholds have a min of 1. Should we add that
in our validation logic on the frontend or will it default to 1 even if 0
is inputted?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#206 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AFHKxRySGkwqzrMcIxSbH_h4q1iwwShgks5uIiCPgaJpZM4VW25M>
.
|
drshrey
approved these changes
Jul 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements front end for health probes
