Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM-997] Add linter rules and fix warnings #50

Merged
merged 1 commit into from Dec 13, 2022

Conversation

mpospese
Copy link
Contributor

Introduction

Our style guide requires the use of implicit return and our library team requires full documentation, so we should add linter rules to enforce these things instead of having to spot them during code review.

Purpose

Update SwiftLint config with implicit_return and missing_docs rules. Fix any linter violations.

Scope

  • Update .swiftlint.yml
  • Fix linter violations

Discussion

YComponentBrowser had multiple violations of the implicit_return rule.

We want to roll out these changes to all of our YML libraries, both in Bitbucket and on GitHub.

Fixes Issue #49

馃搱 Coverage

Unchanged. And documentation coverage should now be enforced by the linter!

@mpospese mpospese merged commit ea0b78e into main Dec 13, 2022
@mpospese mpospese deleted the improvements/CM-997-add-linter-rules branch December 13, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add implicit_return and missing_docs rules to SwiftLint
2 participants