Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localizable.tableName needs a public default implementation #31

Closed
mpospese opened this issue Nov 22, 2022 · 0 comments · Fixed by #32
Closed

Localizable.tableName needs a public default implementation #31

mpospese opened this issue Nov 22, 2022 · 0 comments · Fixed by #32
Assignees
Labels
bug Something isn't working

Comments

@mpospese
Copy link
Contributor

Intro

In Issue #7 we expanded the Localizable protocol with optional tableName. This was intended to have a default implementation (returns nil) but we forgot to mark it as public, so effectively it has no default implementation.

Task

mark Localizable.tableName default implementation (in the extension) as public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging a pull request may close this issue.

1 participant