Rename FontInfo as DefaultFontFamily
#27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpospese
changed the base branch from
main
to
issue/17-rename-system-font-info
timthehelipilot
approved these changes
Sep 21, 2022
mpospese
changed the base branch from
issue/17-rename-system-font-info
to
main
mpospese
force-pushed
the
issue/18-rename-font-info
branch
from
659cfdf
to
0d52c9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Naming is hard! This is the last of 3 renaming PR's. In this one we rename
FontInfoasDefaultFontFamilybecause it is the default implementation of theFontFamilyprotocol and should be named accordingly (also it doesn't provide info about any single font but about a family of fonts).Purpose
Rename
FontInfoasDefaultFontFamily.Scope
FontInfotoDefaultFontFamilyeverywhere (including README)typealiasto original name but mark as deprecated馃搱 Coverage
Coverage should be unchanged by this renaming