[SwiftUI] Add TextStyleLabel #55 #56
Conversation
| let expectedText = Constants.helloWorldText | ||
|
|
||
| let label = TypographyLabel(typography: expectedTypography) | ||
| let labelConfig = { (label: TypographyLabel) in |
There was a problem hiding this comment.
Instead of a local variable, this should be a config passed to the TextStyleLabel initializer.
1st create the sut.
2nd create the label
3rd assert that label.lineBreakMode is not correct
4th call sut.configurationTextStyleLabel(label)
5th assert that label.lineBreakMode was updated.
That proves that the block we passed to the initializer is in fact working.
There was a problem hiding this comment.
You are absolutely right, thank you!!
| labelConfig(label) | ||
|
|
||
| // Given a TypographyLabelRepresentable with a single line of text | ||
| let sut = TextStyleLabel.TypographyLabelRepresentable( |
There was a problem hiding this comment.
Same deal here, we want to pass the config to the sut as a parameter.
| } | ||
| } | ||
|
|
||
| extension TextStyleLabel { |
There was a problem hiding this comment.
SwiftLint is complaining about this and we don't really need the internal view to be declared inside TextStyleLable. Let's remove the extension and just have TypographyLabelRepresentable be declared at top-level.
Sources/YMatterType/Elements/TextStyleLabel.swift:53:9: warning: Nesting Violation: Types should be nested at most 1 level deep (nesting)
Introduction
Create TextStyleLabel component.
Purpose
Allow TypographyLabel with a single line to be used within SwiftUI. Issue #55
Scope
Added new file
TextStyleLabel.swiftand updated the README.mdDiscussion
Unit Tests: Apple doesn鈥檛 provide any testing framework for SwiftUI yet or a way to have UI test within a Swift Package. Since the solution to include unit tests for this component is not straightforward, I'll create a separate PR for it.
馃幀 Video
Apologies for the bad quality (10MB limit issue):
test-video-3.mov