[Issue-68] Fix unit tests that fail in Bold Text mode #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpospese
requested review from
WestonHanners,
sanjibchakraborty,
devyml,
karthikyml and
SahilSainiYML
karthikyml
approved these changes
Mar 17, 2023
devyml
approved these changes
Mar 17, 2023
karthikyml
approved these changes
Mar 17, 2023
mpospese
force-pushed
the
issue/68-unit-tests-fail-bold-text-enabled
branch
from
5f6ce54
to
9a03e54
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
While working on another issue, I noticed that some unit tests would fail if the device (or simulator) the tests were running on had the Accessibility Bold Text feature enabled.
Purpose
Fix #68 Clean up the unit tests so that they pass whether Bold Text is enabled or not.
Scope
Discussion
This wasn't affecting CI/CD or anything because those simulators don't have Bold Text enabled, but it is a flakiness that should be cleaned up and will help ensure that our code is robust.
馃搱 Coverage
Code
Remains unchanged at 97.9% (didn't anticipate any code coverage changes since I didn't add or remove any tests, only provided different font families to test).
Documentation
Documentation coverage remains unchanged at 100% because this PR only affects unit test cases.