New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-13] Add option to disable dismiss UI. #14
Conversation
You kind of swapped Introduction and Purpose. Introduction is the more casual introduction of what the problem is or why we are bothering to make a change at all. Purpose is the stated goal of the PR. So I would do:
|
You also probably should use the Discussion section to talk about why you introduced a new file.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Let's get this merged and release a new version.
Introduction
We have no way of disabling the swipe down, tap on dimmer, or accessibility escape gesture which we use to dismiss the sheet. Some apps might require that the user not be able to dismiss the sheet without choosing a CTA or taking a specific action.
Purpose
Scope
We have added a new property
allowDismiss
in appearance. If it is true then we can dismiss the bottom sheet else we are suspending the dismiss actionDiscussion
BottomSheetViewController.swift had grown too large, so as part of this PR I moved the animator functionality out to a separate code file.
馃搱 Coverage
Code
Documentation