Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue-11] Make dimmer a Close button in VO mode. #23

Merged
merged 9 commits into from Apr 25, 2023

Conversation

devyml
Copy link
Collaborator

@devyml devyml commented Apr 25, 2023

Introduction

In Voice Over mode we should make the transparent area above the sheet a button to enable it to be explicitly tapped.

Purpose

Scope

  • dimmerTapView introduced above the sheet view and accessibility label added for the view.

馃搱 Coverage

Code

Screenshot 2023-04-25 at 12 53 12 PM

Documentation

Screenshot 2023-04-25 at 12 53 33 PM

@devyml devyml self-assigned this Apr 25, 2023
@devyml devyml added the enhancement New feature or request label Apr 25, 2023
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please put back some of the changes you made that were unrelated to the current functionality. If you're still struggling to keep the file small enough, we can find other functionality to extract to separate files.

Sources/YBottomSheet/Enums/AccessibilityIdentifiers.swift Outdated Show resolved Hide resolved
Sources/YBottomSheet/BottomSheetController.swift Outdated Show resolved Hide resolved
Sources/YBottomSheet/BottomSheetController.swift Outdated Show resolved Hide resolved
Sources/YBottomSheet/BottomSheetController.swift Outdated Show resolved Hide resolved
Sources/YBottomSheet/BottomSheetController.swift Outdated Show resolved Hide resolved
Sources/YBottomSheet/BottomSheetController.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@mpospese mpospese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dimmer tap view does not disable (become invisible to VO) when appearance.isDismissAllowed == false

@mpospese
Copy link
Contributor

Also dimmer view is not accessible via VO yet because it's not an accessibility element. I think you need this in updateViewAppearance:

dimmerTapView.isAccessibilityElement = appearance.isDismissAllowed

That solves the problem of it not being accessible normally, but also it not being disabled where appropriate.

@devyml devyml requested a review from mpospese April 25, 2023 11:02
@devyml devyml merged commit 7aff3f6 into main Apr 25, 2023
1 check passed
@devyml devyml deleted the feature/CM-1254-dimmerInVOMode branch April 25, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

Make dimmer a Close button in VO mode
2 participants