New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue-11] Make dimmer a Close button in VO mode. #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put back some of the changes you made that were unrelated to the current functionality. If you're still struggling to keep the file small enough, we can find other functionality to extract to separate files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dimmer tap view does not disable (become invisible to VO) when appearance.isDismissAllowed == false
Also dimmer view is not accessible via VO yet because it's not an accessibility element. I think you need this in
That solves the problem of it not being accessible normally, but also it not being disabled where appropriate. |
Introduction
In Voice Over mode we should make the transparent area above the sheet a button to enable it to be explicitly tapped.
Purpose
Scope
dimmerTapView
introduced above the sheet view and accessibility label added for the view.馃搱 Coverage
Code
Documentation