[CM-1237] Tag border colour issue fixed. #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpospese
reviewed
Mar 15, 2023
There was a problem hiding this comment.
Code looks great, but I'm not sure about that test. I'd actually expect the colors to be different. I think the outcome depends on whether simulator is in dark or light mode, which means flaky test. I think you need to specify a color you know changes (.label), explicitly set the mode to .light then fetch lightBorderColor, then explicitly set mode to .dark and then fetch darkBorderColor. Assert the two CGColor's are different.
mpospese
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Tag border does not update when colour mode changes.
Purpose
Tag border does not update when colour mode changes.
Scope
Border colour updated once the appearance changed.
馃摫 Screenshots
馃搱 Coverage
Code
Documentation