Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort dotfiles first in filename order view #34

Closed
mtlynch opened this issue Aug 8, 2022 · 5 comments
Closed

Sort dotfiles first in filename order view #34

mtlynch opened this issue Aug 8, 2022 · 5 comments
Labels
bug Something isn't working

Comments

@mtlynch
Copy link

mtlynch commented Aug 8, 2022

Thanks for improving the file sort order in #29! That matches my desired sorting, though it behaves unexpectedly with dotfiles or folders with leading dot:

image

Current behavior

  • bundler/create-bundle
  • bundler/verify-bundle
  • .circleci/config.yml
  • bundler/.gitignore
  • bundler/bundle/ansible.cfg

Desired behavior

Most tools (Github, VS Code, bash) seem to sort dotfiles and dotfolders first, so I'd prefer this ordering:

  • .circleci/config.yml (moved to first position)
  • bundler/.gitignore (moved to second position)
  • bundler/create-bundle
  • bundler/verify-bundle
  • bundler/bundle/ansible.cfg
@samatcodeapprove
Copy link

@mtlynch yep that's a bug. As always thank you for the extremely actionable feedback!

@samatcodeapprove samatcodeapprove added the bug Something isn't working label Aug 9, 2022
@samatcodeapprove
Copy link

Deploying a fix for this now!

@mtlynch
Copy link
Author

mtlynch commented Sep 6, 2022

@samatcodeapprove I think there's been a regression here, as the .circleci path is now appearing out of order:

image

@samatcodeapprove
Copy link

Ah thanks for flagging this! Those files without extensions (bundler/create-bundle) were breaking my sort. Pushing a fix for this now.

@mtlynch
Copy link
Author

mtlynch commented Sep 12, 2022

Verified, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants