Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidemenu is not sticky #1032

Closed
wants to merge 2 commits into from
Closed

Conversation

GarySiu
Copy link

@GarySiu GarySiu commented Aug 21, 2019

A workaround implementation for #1021

  • removes overflow: hidden from various places
  • sticky positions the contents of the off-canvas menu

@notapatch
Copy link
Contributor

notapatch commented Sep 22, 2019

Hi @GarySiu,

If you rebase you shouldn't see that error again.

@GarySiu
Copy link
Author

GarySiu commented Sep 23, 2019

Thanks for resolving the CI issues!

@github-actions
Copy link

github-actions bot commented Dec 3, 2020

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale label Dec 3, 2020
@GarySiu
Copy link
Author

GarySiu commented Dec 4, 2020

Leaving a comment so this isn't marked as stale. As far as I know, this can still be merged.

@matyikriszta
Copy link
Contributor

@GarySiu we are working on a PR that should go live soon that is going to remove the sticky sidebar so going to close this PR regardless. Thanks for your contribution and sorry we did not merge this in earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants