Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(1765): remote events #1798

Merged
merged 19 commits into from
Oct 31, 2022
Merged

feat(1765): remote events #1798

merged 19 commits into from
Oct 31, 2022

Conversation

jhackett1
Copy link
Contributor

fixes: #1765

@jhackett1 jhackett1 self-assigned this Aug 20, 2022
@jhackett1
Copy link
Contributor Author

jhackett1 commented Aug 26, 2022 •
edited
Loading

the remaining codeclimate issues seem low priority to me. i can invest some more time in fixing them, but tbh i don't think i caused them—they don't seem to be attached to any code i wrote or changed, even though they're showing up as "new" in the report.

lemme know what you think @KimberleyCook

@matyikriszta
Copy link
Contributor

the remaining codeclimate issues seem low priority to me. i can invest some more time in fixing them, but tbh i don't think i caused them—they don't seem to be attached to any code i wrote or changed, even though they're showing up as "new" in the report.

lemme know what you think @KimberleyCook

@jhackett1 you are right, I have marked those issues for now as won't fix, they are not relevant to this change.

matyikriszta
matyikriszta reviewed Sep 19, 2022
View reviewed changes
Copy link
Contributor

@matyikriszta matyikriszta left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhackett1 can you add an integration test for this change?

@matyikriszta matyikriszta merged commit e8a51ed into master Oct 31, 2022
@matyikriszta matyikriszta deleted the tweaks branch October 31, 2022 06:13
@matyikriszta matyikriszta mentioned this pull request Oct 31, 2022
Closed
7 tasks
@matyikriszta matyikriszta mentioned this pull request Nov 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matyikriszta matyikriszta matyikriszta approved these changes

@KimberleyCook KimberleyCook Awaiting requested review from KimberleyCook

Assignees

@jhackett1 jhackett1

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow remote "Events"
2 participants
@jhackett1 @matyikriszta