feat(1493): events have timezones #1800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matyikriszta
reviewed
Oct 6, 2022
matyikriszta
force-pushed
the
timezone-events
branch
2 times, most recently
from
48c8f43
to
63b253e
Compare
|
This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This PR has been approved but hasn't been merged. Is there anything that's missing that would stop it from being merged (other than being out of sync given how old it is)? |
|
@biggianteye yes, we have tested this PR further and it does not actually work. I'm going to remove the Approval for now. We'll have to revisit this issue, it's on our roadmap. |
matyikriszta
force-pushed
the
timezone-events
branch
5 times, most recently
from
9467e31
to
5743d31
Compare
matyikriszta
reviewed
Jan 4, 2024
matyikriszta
force-pushed
the
timezone-events
branch
from
5743d31
to
de88280
Compare
matyikriszta
force-pushed
the
timezone-events
branch
from
de88280
to
d96df26
Compare
gnclmorais
approved these changes
Jan 6, 2024
matyikriszta
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #1493