Adds a photo to the initial sign up page #1826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
KimberleyCook
commented
Nov 10, 2022
•
KimberleyCook
commented
| Before | After |
|---|---|
 |
 |
gnclmorais
approved these changes
Nov 14, 2022
There was a problem hiding this comment.
@KimberleyCook this is a great idea, can we maybe try a two column layout on desktop? I think it would be better if the buttons would be preceded by the text vs the image.
matyikriszta
force-pushed
the
add-photo-to-sign-up-page
branch
from
2f3da76
to
b7e5f0f
Compare
|
@KimberleyCook I hope you don't mind, I checked out and reworked this PR a little. This is what I came up with in terms of layout, I wanted to get rid of that unsightly student button.
|
matyikriszta
force-pushed
the
add-photo-to-sign-up-page
branch
from
b7e5f0f
to
7b34599
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.