Update New announcement form to ensure group names are properly displayed in the Select groups dropdown #1965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@KimberleyCook feel free to merge and deploy this once merged, no need to wait for me until I'm online |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We noticed that in the New announcement form the Select groups dropdown would only display groups by their name (e.g. Student or Coach) without the city name attached, so it was impossible to tell what groups we were assigning announcements to. This PR updates the form field to display the group name in the following format
"#{name} #{chapter.name}"Status
Ready for Review
Screenshots